[compiler-rt] r288672 - Remove a couple of memset usages from TSan, introduced in r288624.
Daniel Jasper via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 5 06:37:42 PST 2016
Author: djasper
Date: Mon Dec 5 08:37:42 2016
New Revision: 288672
URL: http://llvm.org/viewvc/llvm-project?rev=288672&view=rev
Log:
Remove a couple of memset usages from TSan, introduced in r288624.
TSan runtime shouldn't contain memset, so internal_memset is used
instead and syntax that emits memset is avoided.
This doesn't fail in-tree due to TSan being build with -03, but it fails
when TSan is built with -O0, and is (I think) a true positive.
Patch by Sam McCall, review: https://reviews.llvm.org/D27407
Modified:
compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc?rev=288672&r1=288671&r2=288672&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc Mon Dec 5 08:37:42 2016
@@ -152,8 +152,10 @@ bool SymbolizerProcess::StartSymbolizerS
int pid = -1;
- int infd[2] = {};
- int outfd[2] = {};
+ int infd[2];
+ internal_memset(&infd, 0, sizeof(infd));
+ int outfd[2];
+ internal_memset(&outfd, 0, sizeof(outfd));
if (!CreateTwoHighNumberedPipes(infd, outfd)) {
Report("WARNING: Can't create a socket pair to start "
"external symbolizer (errno: %d)\n", errno);
More information about the llvm-commits
mailing list