[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

Stephan Bergmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 06:28:10 PST 2016


sberg added a comment.

> Regarding Justin's comment on the mono repo, I grepped https://github.com/llvm-project/llvm-project/ for "APFloat", and found out that klee/lib/Core/Executor.cpp, clang-tools-extra/clang-tidy/misc/IncorrectRoundings.cpp, multiple files from lldb, and dragonegg do use these semantics, besides libcxx and clang.'

So besides the places I'd already covered in llvm, clang, and clang-tools-extra, I've now also covered lldb and klee (even though the latter isn't part of the monorepo's -DLLVM_ENABLE_PROJECTS=all).  (I didn't find any hits in dragonegg?)  See https://github.com/stbergmann/llvm-project/commit/f914d64f6ba3506d04ec8e74f859aea17a695497 for the full patch.

> If you use svn, just apply all patches in a single commit; or you can use the git monorepo check-in script, see http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo .

But I can't upload such a single patch here in Phabricator, right?


https://reviews.llvm.org/D26671





More information about the llvm-commits mailing list