[PATCH] D25046: AMDGPU: Emit runtime metadata version 2 as YAML

[Nikolay Haustov via Phabricator via llvm-commits]

nhaustov added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPURuntimeMetadata.h:111
     enum AccessQualifer : uint8_t {
       None       = 0,
       ReadOnly   = 1,
----------------
Can 'None' be renamed to something less generic? I'm getting conflict with X11 headers define :(
/srv/dk/lnx/xfree86/7.4_64a/include/X11/X.h:120:30: error: expected identifier before numeric constant
 #define None                 0L /* universal null resource or null atom */
                              ^
../../../../../../compiler/llvm/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h:111:7: note: in expansion of macro 'None'
       None       = 0,
       ^



================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPURuntimeMD.cpp:23
+#include "llvm/IR/Module.h"
+#include "llvm/Support/CommandLine.h"
+#include "llvm/Support/raw_ostream.h"
----------------
Also needs include of "llvm/ADT/StringSwitch.h".


https://reviews.llvm.org/D25046