[PATCH] D27119: Use Darwin libtool's -no_warning_for_no_symbols if available to silence the "has no symbols" link warning

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 20:49:56 PST 2016


beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One minor nit below, otherwise LGTM.



================
Comment at: CMakeLists.txt:77
+
+    set(LIBTOOL_NO_WARNING_FLAG "")
+    execute_process(COMMAND ${CMAKE_LIBTOOL} -V
----------------
You don't need to set the variable to empty, an unset variable will evaluate to empty anyways.


https://reviews.llvm.org/D27119





More information about the llvm-commits mailing list