[PATCH] D27399: [tsan] Unify the stack trace render format between TSan and ASan

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubabrecka created this revision.
kubabrecka added a reviewer: dvyukov.
kubabrecka added subscribers: llvm-commits, zaks.anna.
kubabrecka set the repository for this revision to rL LLVM.
kubabrecka added a project: Sanitizers.

I always found it weird that TSan print backtraces in a different line format than ASan.  Would it make sense to unify them?

In particular, I care about having the actual PC addresses in the stack frames.  This is useful for pointing to the exact instruction that caused a race.


Repository:
  rL LLVM

https://reviews.llvm.org/D27399

Files:
  lib/tsan/rtl/tsan_flags.cc


Index: lib/tsan/rtl/tsan_flags.cc
===================================================================
--- lib/tsan/rtl/tsan_flags.cc
+++ lib/tsan/rtl/tsan_flags.cc
@@ -69,7 +69,6 @@
       cf.detect_deadlocks = true;
     }
     cf.print_suppressions = false;
-    cf.stack_trace_format = "    #%n %f %S %M";
     cf.exitcode = 66;
     cf.intercept_tls_get_addr = true;
     OverrideCommonFlags(cf);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27399.80224.patch
Type: text/x-patch
Size: 401 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161205/1f119abb/attachment.bin>