[PATCH] D9386: llvm.noalias - CaptureTracking needs to look through them

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 18:35:26 PST 2016


hfinkel added inline comments.


================
Comment at: lib/Analysis/CaptureTracking.cpp:244
+        if (Count++ >= Threshold)
+          return Tracker->tooManyUses();
+
----------------
jeroen.dobbelaere wrote:
> Moving this piece of code with a 'return' into a lambda results in a behavior change: instead of directly breaking the outer while loop when the Threshold is reached, it will now keep doing work with whatever is on the worklist. I don't think this change in behavior was intended.
You're right, thanks!


https://reviews.llvm.org/D9386





More information about the llvm-commits mailing list