[llvm] r288601 - AMDGPU: remove a couple of unused variables
Saleem Abdulrasool via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 3 14:25:22 PST 2016
Author: compnerd
Date: Sat Dec 3 16:25:21 2016
New Revision: 288601
URL: http://llvm.org/viewvc/llvm-project?rev=288601&view=rev
Log:
AMDGPU: remove a couple of unused variables
lib/Target/AMDGPU/SIRegisterInfo.cpp: In member function 'void llvm::SIRegisterInfo::spillSGPR(llvm::MachineBasicBlock::iterator, int, llvm::RegScavenger*) const':
lib/Target/AMDGPU/SIRegisterInfo.cpp:572:30: warning: variable 'SubRC' set but not used [-Wunused-but-set-variable]
const TargetRegisterClass *SubRC = nullptr;
^
lib/Target/AMDGPU/SIRegisterInfo.cpp: In member function 'void llvm::SIRegisterInfo::restoreSGPR(llvm::MachineBasicBlock::iterator, int, llvm::RegScavenger*) const':
lib/Target/AMDGPU/SIRegisterInfo.cpp:723:30: warning: variable 'SubRC' set but not used [-Wunused-but-set-variable]
const TargetRegisterClass *SubRC = nullptr;
^
The variable was assigned to, but never used. The functions called did not
mutate state. Simplify the logic and remove the variable. Identified by gcc
5.4.0.
Modified:
llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.cpp
Modified: llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.cpp?rev=288601&r1=288600&r2=288601&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.cpp Sat Dec 3 16:25:21 2016
@@ -569,14 +569,8 @@ void SIRegisterInfo::spillSGPR(MachineBa
std::tie(EltSize, ScalarStoreOp) = getSpillEltSize(RC->getSize(), true);
}
- const TargetRegisterClass *SubRC = nullptr;
- unsigned NumSubRegs = 1;
ArrayRef<int16_t> SplitParts = getRegSplitParts(RC, EltSize);
-
- if (!SplitParts.empty()) {
- NumSubRegs = SplitParts.size();
- SubRC = getSubRegClass(RC, SplitParts[0]);
- }
+ unsigned NumSubRegs = SplitParts.empty() ? 1 : SplitParts.size();
// SubReg carries the "Kill" flag when SubReg == SuperReg.
unsigned SubKillState = getKillRegState((NumSubRegs == 1) && IsKill);
@@ -720,14 +714,8 @@ void SIRegisterInfo::restoreSGPR(Machine
std::tie(EltSize, ScalarLoadOp) = getSpillEltSize(RC->getSize(), false);
}
- const TargetRegisterClass *SubRC = nullptr;
- unsigned NumSubRegs = 1;
ArrayRef<int16_t> SplitParts = getRegSplitParts(RC, EltSize);
-
- if (!SplitParts.empty()) {
- NumSubRegs = SplitParts.size();
- SubRC = getSubRegClass(RC, SplitParts[0]);
- }
+ unsigned NumSubRegs = SplitParts.empty() ? 1 : SplitParts.size();
// SubReg carries the "Kill" flag when SubReg == SuperReg.
int64_t FrOffset = FrameInfo.getObjectOffset(Index);
More information about the llvm-commits
mailing list