[PATCH] D27378: [asan] Teach asan_symbolize.py to use :arch with atos and llvm-symbolizer on Darwin

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubabrecka created this revision.
kubabrecka added reviewers: filcab, zaks.anna, kcc, eugenis, glider, dvyukov.
kubabrecka added a subscriber: llvm-commits.
kubabrecka set the repository for this revision to rL LLVM.
kubabrecka added a project: Sanitizers.

On Darwin, there is an issue with llvm-symbolizer and atos, where we cannot properly symbolize when mixing x86_64 and x86_64h modules within one process.  This is a very common case on macOS (x86_64h is backwards compatible, so when there is no x86_64h slice, a regular x86_64 is loaded instead).  This currently makes some compiler-rt tests fail on Haswell+ Darwin machines.

This patch teaches asan_symbolize.py to read an architecture suffix on module names (e.g. ":x86_64") and pass that option to atos and llvm-symbolizer.  Follow-up patches will fix the same problem when invoking llvm-symbolizer directly from sanitizers.


Repository:
  rL LLVM

https://reviews.llvm.org/D27378

Files:
  lib/asan/scripts/asan_symbolize.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27378.80160.patch
Type: text/x-patch
Size: 6368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161203/1b2ad410/attachment.bin>