[PATCH] D27297: [ELF] - Disable relro when -omagic specified.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Driver.cpp:578
 
+  if (Config->OMagic)
+    Config->ZRelro = false;
----------------
Please add comments as it's not obvious.

  // --omagic is an option to create old-fashioned executables in which
  // .text segments are writable. Today, the option is still in use to
  // create special-purpose programs such as boot loaders. It doesn't
  // make sense to create PT_GNU_RELRO for such executables.


https://reviews.llvm.org/D27297