[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

[Tim Shen via Phabricator via llvm-commits]

timshen added a comment.

In https://reviews.llvm.org/D26671#611490, @sberg wrote:

> In https://reviews.llvm.org/D26671#611268, @timshen wrote:
>
> > As far as I can tell, Clang actively uses these semantics, so I expect this change to break clang build. Do you have other patches to adjust other repositories?
>
>
> see my previous: "Checked additional repos tools/clang and tools/clang/tools/extra (which each needs a corresponding patch, which I'll submit once the details of this one are discussed), projects/libcxxabi (which mentions those data members' mangled names in test/test_demangle.pass.cpp, but apparently only as sample test data, so doesn't need changing?), projects/libcxx, and project/compiler-rt (which are unaffected). Is there a list of more repos to check? (And how would commits for such an incompatible cross-repo change be done atomically?)"


Regarding Justin's comment on the mono repo, I grepped https://github.com/llvm-project/llvm-project/ for "APFloat", and found out that klee/lib/Core/Executor.cpp, clang-tools-extra/clang-tidy/misc/IncorrectRoundings.cpp, multiple files from lldb, and dragonegg do use these semantics, besides libcxx and clang.'

However, the github monorepo doesn't seem to hold all llvm projects, see https://llvm.org/svn/llvm-project/.

I'm not sure whether you should change them all together, or it's fine to leave some repositories broken in a very short period of time.

> 
> 
>> I don't know if it's necessary, but it's better to have them checked in in a single svn commit.
> 
> How do I do that?  Any pointer?

If you use svn, just apply all patches in a single commit; or you can use the git monorepo check-in script, see http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo .


https://reviews.llvm.org/D26671