[PATCH] D27361: [DIExpression] Introduce a dedicated DW_OP_LLVM_fragment operation so we can stop using DW_OP_bit_piece with the wrong semantics.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfExpression.cpp:116
         // non-zero offset, we need to manually shift the value into
-        // place, since the DW_OP_piece describes the part of the
+        // place, since the DW_OP_fragment describes the part of the
         // variable, not the position of the subregister.
----------------
probinson wrote:
> DW_OP_LLVM_fragment (or DW_OP_piece if it really is still that).
The code here is not wrong, but do not have to do any manual shifting if we use DW_OP_bit_piece correctly here. I will fix this in a subsequent patch.


https://reviews.llvm.org/D27361