[PATCH] D27336: [globalisel][aarch64] Replace magic numbers with corresponding enumerators in ValMappings. NFC

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM modulo minor nitpicks.



================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:41
+  LastFPR = FPR512,
+  PartialMappingIdx_Min = FirstGPR,
 };
----------------
I'd use a shorter name: MinIdx or FirstIdx


================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:85
   // 0: GPR 32-bit value. <-- This must match First3OpsIdx.
-  {&PartMappings[0], 1}, {&PartMappings[0], 1}, {&PartMappings[0], 1},
+  {&PartMappings[GPR32 - PartialMappingIdx_Min], 1}, {&PartMappings[GPR32 - PartialMappingIdx_Min], 1}, {&PartMappings[GPR32 - PartialMappingIdx_Min], 1},
   // 3: GPR 64-bit value.
----------------
Could you clang-format those lines?


https://reviews.llvm.org/D27336