[PATCH] D24956: [SelectionDAG] Add expansion and promotion of [US]MUL_LOHI

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: include/llvm/Target/TargetLowering.h:3053
+                      SDValue RHS, SmallVectorImpl<SDValue> &Result, EVT HiLoVT,
+                      SelectionDAG &DAG, bool OnlyLegalOrCustom,
+                      SDValue LL = SDValue(), SDValue LH = SDValue(),
----------------
Please make OnlyLegalOrCustom an enum; otherwise it's completely impossible to tell what the parameter does without looking at the header.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2210
     // Hacker's Delight (itself derived from Knuth's Algorithm M from section
     // 4.3.1).
     unsigned Bits = NVT.getSizeInBits();
----------------
Can you replace this code with a call to expandMUL?


https://reviews.llvm.org/D24956