[PATCH] D27344: AMDGPU: Properly implement SIRegisterInfo::isFrameOffsetLegal and needsFrameBaseReg

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/local-stack-slot-offset.ll:16-17
+main_body:
+  %slot1 = insertelement <513 x float> undef, float %v1, i32 %idx1
+  %slot2 = insertelement <513 x float> undef, float %v2, i32 %idx2
+
----------------
nhaehnle wrote:
> arsenm wrote:
> > Can you come up with a testcase which doesn't use an enormous illegal vector type? These end up having really bad compile time and I've been meaning to fix the ones we already have 
> Hmm, maybe something with -promote-alloca?
Yes, most of our private memory tests need to use that


https://reviews.llvm.org/D27344