[PATCH] D27321: Fix LSR ImmCost calculation for profitable chains

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi,

I am not sure I get the problem you are trying to solve.
You are saying that we want to account for an extra cost if the setting outside of the base is big, right?
Then, why is the average offset relevant to answer that question?

Thanks,
-Quentin



================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:991
 
+  // Number of same base addresses.
+  unsigned SameBaseAddress;
----------------
Use oxygen style: ///


================
Comment at: test/Transforms/LoopStrengthReduce/X86/imm-cost.ll:26
+  %incdec.ptr = getelementptr inbounds i8, i8* %inptr.014, i64 1
+  %0 = load i8, i8* %inptr.014, align 1
+  %conv = sext i8 %0 to i32
----------------
Use opt -instnamer to get rid of implicit variables.


Repository:
  rL LLVM

https://reviews.llvm.org/D27321