vpykhtin added inline comments. ================ Comment at: test/CodeGen/AMDGPU/unify-metadata.ll:20 +!1 = !{i32 1, i32 2} +!2 = !{!"clang version 4.0 "} ---------------- How about adding test for deduplicating extension strings? Repository: rL LLVM https://reviews.llvm.org/D25381