[PATCH] D25318: [DAG] Don't increase SDNodeOrder for dbg.value/declare.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.



In https://reviews.llvm.org/D25318#611530, @uabelho wrote:

> In https://reviews.llvm.org/D25318#611529, @fhahn wrote:
>
> > I've uploaded two test cases in https://reviews.llvm.org/D27261, one with checks for AArch64 and one with checks for X86. I think it would be good to use those, as the test code in this review wasn't problementic on Aarch64.
>
>
> Sure! Should I simply remove "my" test and add "your" tests in this patch or how do we do it?


Yes I think the easiest thing would be for you to just add my tests to your review.

>> ideally we would have a general test that checks that all produced assembler instructions are equal, but I don't think there's a way to do that with FileCheck (and without pulling in other tools as dependency for the test).
> 
> Yep! That's kind of how we do it for our out-of-tree target and that's how I found this bug. We compile random C-programs with and without -g and verify that the .text sections in the object files are identical but of course it then pulls in other tools to be able to do that. :/

There's a utility in the clang repo (clang/utils/check_cfc), but I don't think it's used in any tests and we should have CodGen tests for the patch in llvm anyways.


https://reviews.llvm.org/D25318