[PATCH] D27295: Remove existing file in a separate thread asynchronously.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 00:09:27 PST 2016


silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision is now accepted and ready to land.

Overall, I do like the idea of doing this and this LGTM (although let others chime in). One thing to think about is that if it takes this long to delete a file (even on tmpfs which Joerg mentioned), then how long does it take to allocate the memory for a new file? (let alone write it to disk)

So there is probably a similar cost hidden somewhere else that we could maybe get rid of if we arranged things right (not in this patch though).


https://reviews.llvm.org/D27295





More information about the llvm-commits mailing list