[PATCH] D26989: Use continuous boosting factor for complete unroll.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh marked an inline comment as done.
danielcdh added a comment.

In https://reviews.llvm.org/D26989#611319, @mzolotukhin wrote:

> Hi Dehao,
>
> Sorry for the delay, I missed the patch for some reason.
>
> A couple of initial remarks:
>
> 1. Could you split unrelated changes into a separate (probably, NFC) patch? For instance, changing `int` to `unsigned`.


Done

> 2. Did you check compile-time impact of this change? LLVM-testsuite exposed a couple of problems with the original version, so I wonder if it's ok with the new one.

I checked the compile time impact on speccpu2006, no noticeable compile time change is observed.

Thanks,
Dehao

> Thanks,
> Michael





================
Comment at: lib/Transforms/InstCombine/InstCombinePHI.cpp:570
                                    PhiVal, ConstantOp);
-  NewCI->setDebugLoc(FirstInst->getDebugLoc());
   return NewCI;
----------------
mzolotukhin wrote:
> Why do we need to remove it?
This is irrelevant, removed the change.


https://reviews.llvm.org/D26989