[PATCH] D27315: [ARM] Fix for 64-bit CAS expansion on ARM32 with -O0

[Oleg Ranevskyy via Phabricator via llvm-commits]

iid_iunknown marked an inline comment as done.
iid_iunknown added inline comments.


================
Comment at: lib/Target/ARM/ARMExpandPseudoInsts.cpp:938
 
-  unsigned SBCrr = IsThumb ? ARM::t2SBCrr : ARM::SBCrr;
-  MIB = BuildMI(LoadCmpBB, DL, TII->get(SBCrr))
-            .addReg(StatusReg, RegState::Define | RegState::Dead)
+  MIB = BuildMI(LoadCmpBB, DL, TII->get(CMPrr))
             .addReg(DestHi, getKillRegState(Dest.isDead()))
----------------
t.p.northover wrote:
> You can probably drop the "MIB =" here. Otherwise everything looks fine though. Thanks for fixing this!
Yes, you are right. I've updated the patch.

Thanks for your review, Tim!


Repository:
  rL LLVM

https://reviews.llvm.org/D27315