[PATCH] D26817: [APFloat] Implement PPCDoubleDouble add and subtract.

[Kit Barton via Phabricator via llvm-commits]

kbarton added a comment.

I looked through this, but my review is mostly superficial as I don't have the background to be able to comment on the logic here.



================
Comment at: llvm/lib/Support/APFloat.cpp:4069
+  }
+  llvm_unreachable("");
+}
----------------
Why is this an empty string?


================
Comment at: llvm/lib/Support/APFloat.cpp:4076
+
+bool DoubleAPFloat::isNegative() const { return Floats[0].isNegative(); }
+
----------------
Is it possible for Floats[1] to ever be negative?


https://reviews.llvm.org/D26817