[PATCH] D27076: Object: Set SF_Indirect in ModuleSymbolTable.

[Peter Collingbourne via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL288321: Object: Set SF_Indirect in ModuleSymbolTable. (authored by pcc).

Changed prior to commit:
  https://reviews.llvm.org/D27076?vs=79852&id=79874#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D27076

Files:
  llvm/trunk/lib/Object/ModuleSymbolTable.cpp
  llvm/trunk/tools/llvm-nm/llvm-nm.cpp


Index: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
===================================================================
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp
@@ -998,13 +998,8 @@
     uint32_t SymFlags = Sym.getFlags();
     if (!DebugSyms && (SymFlags & SymbolRef::SF_FormatSpecific))
       continue;
-    if (WithoutAliases) {
-      if (IRObjectFile *IR = dyn_cast<IRObjectFile>(&Obj)) {
-        const GlobalValue *GV = IR->getSymbolGV(Sym.getRawDataRefImpl());
-        if (GV && isa<GlobalAlias>(GV))
-          continue;
-      }
-    }
+    if (WithoutAliases && (SymFlags & SymbolRef::SF_Indirect))
+      continue;
     // If a "-s segname sectname" option was specified and this is a Mach-O
     // file and this section appears in this file, Nsect will be non-zero then
     // see if this symbol is a symbol from that section and if not skip it.
Index: llvm/trunk/lib/Object/ModuleSymbolTable.cpp
===================================================================
--- llvm/trunk/lib/Object/ModuleSymbolTable.cpp
+++ llvm/trunk/lib/Object/ModuleSymbolTable.cpp
@@ -166,6 +166,8 @@
   }
   if (dyn_cast_or_null<Function>(GV->getBaseObject()))
     Res |= BasicSymbolRef::SF_Executable;
+  if (isa<GlobalAlias>(GV))
+    Res |= BasicSymbolRef::SF_Indirect;
   if (GV->hasPrivateLinkage())
     Res |= BasicSymbolRef::SF_FormatSpecific;
   if (!GV->hasLocalLinkage())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27076.79874.patch
Type: text/x-patch
Size: 1415 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161201/77978d5d/attachment.bin>