[PATCH] D27073: Object: Extract a ModuleSymbolTable class from IRObjectFile.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D27073#610236, @pcc wrote:

> Not sure if we'll need accessors. I'd expect that clients which need this information (essentially just the symbol table writer, eventually) would just pull the information out of the module that they presumably have


The BitcodeModule you mean? Because we're not supposed to have a llvm::Module anymore (the patch I had was removing `llvm::Module` entirely from `LTOModule` I believe, and still exposing `LTOModule::getTargetTriple`.

> I don't think I understand why we'd want all of the module asm. I'd have imagined that we would serialize the AsmSymbols along with the IR symbols. Or is that the IR change you were alluding to?

The issue is that we can't make Bitcode serialization dependent on the ASM Parser. So we'd need to change the IR representation for inline ASM. We discussed it here https://llvm.org/bugs/show_bug.cgi?id=28970


https://reviews.llvm.org/D27073