[PATCH] D27073: Object: Extract a ModuleSymbolTable class from IRObjectFile.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 20:59:39 PST 2016


mehdi_amini added a comment.

The `class BitcodeSymbolTable` I extracted in https://reviews.llvm.org/D23132 had:

  std::string Triple;
  std::string Datalayout;
  std::string ModuleAsm;
  std::string SourceFilename;

I think Triple/Datalayout/SourceFilename are likely to be useful as part of the bitcode symbol table (and having them now would allow you to add the assertion I mentioned earlier).

For the ModuleASM, it is not clear to me yet: unless we change the IR I think we won't be able to avoid it either.


https://reviews.llvm.org/D27073





More information about the llvm-commits mailing list