[PATCH] D27235: [libFuzzer] Diff 5 - Split FuzzerExtFunction implementation for Linux, Apple and Windows.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 19:15:03 PST 2016


mpividori added inline comments.


================
Comment at: lib/Fuzzer/CMakeLists.txt:14
     FuzzerDriver.cpp
-    FuzzerExtFunctionsDlsym.cpp
-    FuzzerExtFunctionsWeak.cpp
+    FuzzerExtFunctionsApple.cpp
+    FuzzerExtFunctionsLinux.cpp
----------------
kcc wrote:
> do you have to change the file names? 
> We've spent quite some time with the Apple folks bike-shedding about these names... 
> 
@kcc We have 3 different implementations, one for Windows, one for Apple and one for Linux. So I thought it would be sensible to name the files this way. What would you suggest?


Repository:
  rL LLVM

https://reviews.llvm.org/D27235





More information about the llvm-commits mailing list