[PATCH] D27188: Use trigrams to speed up SpecialCaseList.
    Ivan Krasin via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Nov 30 17:08:35 PST 2016
    
    
  
krasin added a comment.
In https://reviews.llvm.org/D27188#610048, @pcc wrote:
> Maybe I'm not making myself clear. This test doesn't pass on my machine.
>
>   TEST_F(TrigramIndexTest, foo) {
>     std::unique_ptr<TrigramIndex> TI = makeTrigramIndex(
>         {"class1.h", "class2.h", "class3.h", "class4.h", "class.h"});
>     EXPECT_FALSE(TI->isDefeated());
>   }
Ah, yes, I incorrectly read your example. I thought class.h was a query, not a rule. Yes, that's correct, and I will add this test case as well (although, I have a similar one already).
https://reviews.llvm.org/D27188
    
    
More information about the llvm-commits
mailing list