[PATCH] D27185: Move FrameInstructions from MachineModuleInfo to MachineFunction
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 30 16:03:11 PST 2016
MatzeB added a comment.
In https://reviews.llvm.org/D27185#609891, @echristo wrote:
> May also slightly increase memory usage, but is still the right thing.
>
> LGTM.
>
> -eric
Thanks for the review!
For the record: Currently we only ever have 1 MachineFunction alive at the same time. So whether the data lives in MMI or that 1 MF instance should give us the same memory usage. We just may see some extra malloc/free traffic because we now recreate the container for every function instead of reusing the same one in MMI, but I don't expect that to have any measurable effect.
(Of course memory usage with a MachineModulePass in place increases necessarily and is unavoidable but that is a different discussion)
Repository:
rL LLVM
https://reviews.llvm.org/D27185
More information about the llvm-commits
mailing list