[PATCH] D27244: MCStreamer: Use "cfi" for CFI related temp labels.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 15:35:47 PST 2016


MatzeB added a comment.

In https://reviews.llvm.org/D27244#609914, @rnk wrote:

> Why do we need to print labels for CFI at all? The labels generally aren't referenced anywhere, and they only pollute the assembly output. The assembler creates internal labels when processing .cfi_* and .seh_* directives.


The labels do get stored in some `CurFrame`/`WinFrameInfo` object thingies. So I assume they get used at least in some circumstances. But it would indeed be really nice to not output them if they are unused. If the assembler does something for you even better, but is that also true in the case where we stream to an object file immediately instead of the assembler?

Anyway I don't know much about these parts of the code and go with the easy renaming to "cfi" for now. I'd love to see someone removing the unnecessary labels of course ;-)


Repository:
  rL LLVM

https://reviews.llvm.org/D27244





More information about the llvm-commits mailing list