[PATCH] D27234: [libFuzzer] Diff 4 - Split FuzzerUtil implementation for Posix and Windows.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Fuzzer/FuzzerUtil.cpp:217
   size_t N;
-  while ((N = fread(Buff, 1, sizeof(Buff), Pipe)) > 0)
+  while ((N = fread(Buff, 1, sizeof(Buff), Pipe)) == sizeof(Buff))
     Out->append(Buff, N);
----------------
why this change from >0 to == sizeof(Buff)

In general, please avoid mixing refactoring and functionality changes. 


================
Comment at: lib/Fuzzer/FuzzerUtil.h:66
+
+const void *memmem(const void *haystack, size_t haystacklen,
+                   const void *needle, size_t needlelen);
----------------
This sounds wrong. This declares "fuzzer::memmem",  while on Linux we actually use "memmem"


Repository:
  rL LLVM

https://reviews.llvm.org/D27234