[PATCH] D27133: Introduce element-wise atomic memcpy and memmove intrinsics

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4932
+        return RTLIB::MEMMOVE_ELEMENT_ATOMIC;
+      default: llvm_unreachable("shouldn't happen");
+      }
----------------
do we need a switch case here? the main switch case on the intrinsic is only triggered for memcpy and memmove (line 4901). Maybe we can have it as a ternary with just `memcpy_element_atomic` and `memmove_element_atomic`?


================
Comment at: lib/IR/Verifier.cpp:3963
+           CS);
+    break;
+  }
----------------
Don't we need verification that the source and dest are of same addrspace?


https://reviews.llvm.org/D27133