[PATCH] D27195: [ARM] GlobalISel: Lower more than 4 arguments

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: lib/Target/ARM/ARMCallLowering.cpp:51
+  void assignValueToReg(unsigned ValVReg, unsigned PhysReg,
+                        CCValAssign &VA) override {
+    assert(VA.isRegLoc() && "Value shouldn't be assigned to reg");
----------------
t.p.northover wrote:
> This is silently ignoring the signext/zeroext modifiers that are needed to correctly handle small types on AAPCS. It'd probably be better to fallback or assert if they're not being supported yet.
I would recommend to change the ValueHandler APIs to return boolean so we can indeed fallback while stuff is not supported.


https://reviews.llvm.org/D27195