[PATCH] D26648: Clarify semantic of reserved registers.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Matthias,

LGTM.
One suggestion though.

Cheers,
-Quentin



================
Comment at: include/llvm/Target/TargetRegisterInfo.h:950
+  /// of the set as well.
+  void assertAllSuperRegsMarked(const BitVector &RegisterSet,
+      ArrayRef<MCPhysReg> Exceptions = ArrayRef<MCPhysReg>()) const;
----------------
I'd change the API a bit:
- Rename in checkAllSuperRegsMarked
- Return bool
- Have the users assert on that bool.

The rationale is that in release build `assert(checkAllSuperRegsMarked)` can be optimized out, but `assertAllSuperRegsMarked` would still cause a call to an empty function.


Repository:
  rL LLVM

https://reviews.llvm.org/D26648