[PATCH] D26277: [SLP] Fixed cost model for horizontal reduction.

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 10:09:59 PST 2016


mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

Ok, now I see, in this case it doesn't make sense to separate the two. 
(Sorry for the response time, I was on vacation)

LGTM, except that I would still like to see a test for the scalar cost as part of the final patch you commit. Having the test to begin with (showing 17 -> 11 and 16 -> 7 together) would have saved us some miscommunication.


https://reviews.llvm.org/D26277





More information about the llvm-commits mailing list