[PATCH] D27233: [libFuzzer] Diff 3 - Split IO implementation for Windows and Posix.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

Note: I rely on the other reviewers for the windows-specific parts.



================
Comment at: lib/Fuzzer/FuzzerIO.cpp:19
 #include <sys/stat.h>
+#if LIBFUZZER_POSIX
 #include <unistd.h>
----------------
can you avoid this ifdef? 
E.g. move whatever needs  unistd.h into *Posix* file


================
Comment at: lib/Fuzzer/FuzzerIOPlatform.h:1
+//===- FuzzerIOPlatform.h - Internal header for IO plat. utils --*- C++ -* ===//
+//
----------------
why do we need both FuzzerIO.h and FuzzerIOPlatform.h? 


Repository:
  rL LLVM

https://reviews.llvm.org/D27233