[PATCH] D27103: [Constants] Represent the runtime length of a scalable vector. [IR support for SVE scalable vectors 3/4]

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Assuming we're all happy with vscale, and all noted concerns are addressed, I don't see anything wrong with this patch.

Just reminding, this is not an approval. As we discussed on the list, any final IR change decision will be taken on the list, after extensive review by more than just the few folks that are looking at these patches.



================
Comment at: lib/IR/Constants.cpp:1363
 
-UndefValue *UndefValue::get(Type *Ty) {
-  std::unique_ptr<UndefValue> &Entry = Ty->getContext().pImpl->UVConstants[Ty];
----------------
Ouch, ok, this is a separate thing that can be done now, independent of vscale. Please move this to a different patch and propose it on a new review on its own.


https://reviews.llvm.org/D27103