[PATCH] D27156: Add `isRelExprOneOf` helper (alternative to D27145).

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 00:40:06 PST 2016


silvas added a comment.

> the original simple-minded constexpr containing a for-loop

There wasn't a for loop. It was still recursive in the constexpr case.

Thinking about this for a little bit, I actually like the extra clarity at the use site for the template approach. If you don't mind, I would like to keep it that way.
The templates are not any more complicated (they are both a recursive approach). The templates are slightly more lines of code, but the conceptual complexity is still the same.


https://reviews.llvm.org/D27156





More information about the llvm-commits mailing list