[PATCH] D27075: Object: Add SF_Text symbol flag.

[Rafael Avila de Espindola via llvm-commits]

Peter Collingbourne <peter at pcc.me.uk> writes:

> pcc added inline comments.
>
>
> ================
> Comment at: llvm/lib/Object/ModuleSymbolTable.cpp:166
> +    if (isa<Function>(GO) && !GO->hasSection())
> +      Res |= BasicSymbolRef::SF_Text;
>    if (GV->hasPrivateLinkage())
> ----------------
> mehdi_amini wrote:
>> Why the test on the presence of a section? Do we have a test that exercise this?
> It's a rough approximation for "is this function in the .text section or not". I don't think there's a test, I'll add one.

But at least for nm we want to print 't' for a function in another
section, no?

LGTM with the hasSection removed or a comment and a test added.