[PATCH] D27228: Release memory to OS only when the requested range covers the entire page

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 15:17:50 PST 2016


alekseyshl added a comment.

It is not _really_a problem, but making pontless call, the one we know is going to fail, is not a good idea to me.



================
Comment at: lib/sanitizer_common/sanitizer_posix_libcdep.cc:59
 
 void ReleaseMemoryToOS(uptr addr, uptr size) {
   madvise((void*)addr, size, MADV_DONTNEED);
----------------
eugenis wrote:
> Is this function still used?
Yes, it is, tsan has a bit more elaborated logic and I decided not to touch it, at least in this patch.


https://reviews.llvm.org/D27228





More information about the llvm-commits mailing list