[PATCH] D27216: [SCEVExpand] do not hoist divisions by zero (PR30935)

[Sebastian Pop via Phabricator via llvm-commits]

sebpop planned changes to this revision.
sebpop added a comment.

Sanjoy, I think your previous patch has fixed one more place SCEVExpander::InsertBinop():
the second assert from your unittest is still failing with the current patch:

  EXPECT_EQ(DivInst->getParent(), DivFromScratchExpansionInst->getParent());

that is an expression built from scratch and inserted in the code at the same place as "x/y".
Let me fix that other place as well.


https://reviews.llvm.org/D27216