[PATCH] D27216: [SCEVExpand] do not hoist divisions by zero (PR30935)

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 13:58:16 PST 2016


sebpop added a comment.

In https://reviews.llvm.org/D27216#608086, @sanjoy wrote:

> I tried to address this some time back in https://reviews.llvm.org/rL286437, but that had to be reverted due to PR30976.  Can you please take a look and make sure that this patch does not have the same problem?
>
> Also, does the C++ unit test case from https://reviews.llvm.org/rL286437 also pass with this patch?  If so, that would be nice to include too.


Yes this patch also fixes PR30942: I marked it as a duplicate of the earlier PR30935.
The patch does not ICE the compiler on the testcase of PR30976.

Thanks Sanjoy for the review: I will submit an updated patch.


https://reviews.llvm.org/D27216





More information about the llvm-commits mailing list