[PATCH] D27224: [Profile] Fix bad interaction of profile counter reset and value profile eviction

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This makes sense. Would you be opposed to combining the C file and the test file? I think it'd improve readability to have the run lines and the check lines in the same place.



================
Comment at: test/profile/Inputs/instrprof-value-prof-reset.c:26
+    // CHECK:  callee_2, 3
+    // ChECK-NEXT: callee_1, 0
+    FPT FP = getCalleeFunc(I);
----------------
Since max-vals-per-site = 2, I think we'd also want CHECK-NOT: callee_0?


================
Comment at: test/profile/Inputs/instrprof-value-prof-reset.c:26
+    // CHECK:  callee_2, 3
+    // ChECK-NEXT: callee_1, 0
+    FPT FP = getCalleeFunc(I);
----------------
vsk wrote:
> Since max-vals-per-site = 2, I think we'd also want CHECK-NOT: callee_0?
nit, could you fix the capitalization here?


https://reviews.llvm.org/D27224