[PATCH] D24699: [asan] Allow re-exec in instrumented unit tests on Darwin (fix unit tests on macOS <=10.10)

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubabrecka added a comment.

In https://reviews.llvm.org/D24699#608011, @filcab wrote:

> IIUC, `ReexecDisabled` being `false` on newer systems will just make us hit `DyldNeedsEnvVariable()` on `MaybeReexec()` which will return `false` (on systems where we'd "prefer" to have `ReexecDisabled` be `true`), hence we'll just be removing the library path from `DYLD_INSERT_VARIABLES` env var (if it's there).
>
> If that's correct, then can we use the same trick as `DyldNeedsEnvVariable` for `ReexecDisabled`? Or am I making these two to be the same issue when they aren't?


That's right.  This is the reason why it's fine to have `ReexecDisable() { return false; }` on all macOS versions.  On older OS versions, we need `return false`, on newer it doesn't matter.


https://reviews.llvm.org/D24699