[PATCH] D27083: [sanitizer] Handle malloc_destroy_zone() on Darwin

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a comment.

Please split this in two commits: The `malloc_zone_destroy` part and the bugfix for `malloc_zones[0]`. They seem orthogonal.

I'd really like a test for the `malloc_zones[0]` problem, though. Is it not possible at all? Does it happen only on certain versions (as in: maybe it was a bug somewhere else)?
Otherwise LGTM, but you might want to check if anyone that's using ASan on the mac on more complex systems (Google Chrome?) have something to say.



================
Comment at: lib/sanitizer_common/sanitizer_malloc_mac.inc:78
+          malloc_zones[0] = malloc_zones[i];
+          malloc_zones[i] = tmp;
+          break;
----------------
Why not this (seems more explicit to me. Not a big deal, though)?
```malloc_zones[i] = malloc_zones[0];
malloc_zones[0] = &sanitizer_zone;```


Repository:
  rL LLVM

https://reviews.llvm.org/D27083