[PATCH] D27130: [AArch64] Fix useful bits detection for BFM instructions

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 23:05:35 PST 2016


srhines added a comment.

This is looking great. We already verified that the patch resolves the original bug that was reported.



================
Comment at: test/CodeGen/AArch64/arm64-bitfield-extract.ll:544
+entry:
+  %shr.i315 = lshr i64 %src, 47
+  %shr.i306.tr = trunc i64 %src2 to i32
----------------
Should all these values be renamed to something more clear? For example, this is probably better as %shr47. Several other long value names below could similarly be improved.


https://reviews.llvm.org/D27130





More information about the llvm-commits mailing list