[PATCH] D27182: [MachO] Add UnknownValueErrors and ability to ignore them.

[Chris Bieneman via Phabricator via llvm-commits]

beanz updated this revision to Diff 79510.
beanz added a comment.

Kevin pointed out in his feedback some problems with the aproach I was taking in the Mach-O code. As I thought through it more, my aproach was really not the right way to go.

This patch simplifies the Mach-O code by keeping the malformedErrors and unknownValue errors separately, then joining them after the constructor exits. This approach minimizes the invasiveness of building error lists, and eliminates the unintended behavioral differences that my initial patch introduced.

Thanks for the feedback Kevin!


https://reviews.llvm.org/D27182

Files:
  include/llvm/Object/Binary.h
  include/llvm/Object/Error.h
  include/llvm/Object/MachO.h
  include/llvm/Object/ObjectFile.h
  include/llvm/Object/SymbolicFile.h
  lib/Object/Binary.cpp
  lib/Object/Error.cpp
  lib/Object/MachOObjectFile.cpp
  lib/Object/MachOUniversal.cpp
  lib/Object/ObjectFile.cpp
  lib/Object/SymbolicFile.cpp
  test/Object/Inputs/macho-unknown-lc-id
  test/Object/macho-unknown-lc-id.test
  tools/obj2yaml/obj2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27182.79510.patch
Type: text/x-patch
Size: 18761 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161129/6c7b2c2b/attachment.bin>