[PATCH] D26718: [llvm] Iterate SmallPtrSet in reverse order to uncover non-determinism in codegen

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/ADT/SmallPtrSet.h:30
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
+extern bool ReverseIterate;
+#endif
----------------
This introduces a dependency from ADT to Support, I'm not sure it is OK.
Also the symbol should be in the LLVM namespace.


================
Comment at: unittests/ADT/ReverseIterationTest.cpp:37
+    ASSERT_EQ(std::get<0>(Tuple), std::get<1>(Tuple));
+}
----------------
The test cannot link without LLVM_ENABLE_ABI_BREAKING_CHECKS I believe.


https://reviews.llvm.org/D26718