[PATCH] D27174: [LiveRangeEdit] Handle instructions with no defs correctly.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 12:33:06 PST 2016


MatzeB added a comment.

I'll leave the review to Wei Mi who wrote that part of the code.

Independent of this fix I wonder what happens when there are multiple definitions in an instruction, or implicit definitions which are not at operand position 0? And based on the description of your error symptoms it sounds like a `if (TargetRegisterInfo::isVirtualReg())` would be a good idea as well.


https://reviews.llvm.org/D27174





More information about the llvm-commits mailing list