[PATCH] D26942: [SelectionDAG] getRawSubclassData should not return HasDebugValue.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:475-488
+  union AllSDNodeBitfields {
+    uint16_t Value;
     SDNodeBitfields SDNodeBits;
     ConstantSDNodeBitfields ConstantSDNodeBits;
     MemSDNodeBitfields MemSDNodeBits;
     LSBaseSDNodeBitfields LSBaseSDNodeBits;
     LoadSDNodeBitfields LoadSDNodeBits;
----------------
This change seems a really big change and completely outside of the scope I suggested. I don't particularly like it (it seems to make things less clear) and I'm not sure what motivates it. Could you instead try the approach I suggested?


https://reviews.llvm.org/D26942