[PATCH] D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support.

Joel Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 09:48:52 PST 2016


joelkevinjones added inline comments.


================
Comment at: lib/Target/AArch64/AArch64.td:39
+def FeatureLSE : SubtargetFeature<"lse", "HasLSE", "true",
+  "Enable ARMv8.1 LSE instructions">;
+
----------------
rengolin wrote:
> t.p.northover wrote:
> > Can we expand "LSE" in the description here? I still can't actually think what it could mean.
> Ditto.
So line 39 should be:
  "Enable ARMv8.1 atomic memory access Large System Extension (LSE) instructions">'
or:
  "Enable ARMv8.1 Large System Extension (LSE) atomic memory access instructions">'
First, second, or something else?


https://reviews.llvm.org/D26621





More information about the llvm-commits mailing list