[PATCH] D26832: [LTO] Add option to generate optimization records

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: llvm/trunk/lib/LTO/LTOCodeGenerator.cpp:570
 
+  finishOptimizationRemarks();
+
----------------
mehdi_amini wrote:
> anemet wrote:
> > anemet wrote:
> > > mehdi_amini wrote:
> > > > Actually there is an issue with this code: the backend can also emit remarks, but they may not be in the file, or the file be truncated because you flushed early but not after the backend it complete.
> > > So I guess we need to call this in compileOptimized.  I'll take a look after the Thanksgiving break.
> > (For the record, there are no remarks emitted during codegen right now but that should hopefully change soon.)
> Yes I think so. It seems that `llvm::PrintStatistics();` is already handled here, this seems somehow the same concept.
Committed this in r288041.


Repository:
  rL LLVM

https://reviews.llvm.org/D26832